Mithril Client verify multi signature #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
force-pushed
the
jpraynaud/147-client-verify-multi-signature
branch
from
05a151b to
2e5bd62
Compare
jpraynaud
force-pushed
the
jpraynaud/147-client-verify-multi-signature
branch
from
2e5fe8d to
2f3f1fc
Compare
AggregatorHandler needs to be able to get certificate details from the Aggregator
* First version of the multi signature Verifier * Update Cargo.toml dependencies * Update entities with new type aliases
* Prefer trait object implementation vs generic * Add new Verifier dependency * Add missing tests for restore snapshot * Cleaned client code for more readability * Remove errors module
jpraynaud
force-pushed
the
jpraynaud/147-client-verify-multi-signature
branch
from
2f3f1fc to
338b079
Compare
ghost
approved these changes
May 4, 2022
|
|
||
| #[dev-dependencies] | ||
| rand_core = "0.6.3" |
There was a problem hiding this comment.
Why do we need the client to be aware of these? Couldn't we reexport types from the mithril-core library?
There was a problem hiding this comment.
Yes, reexport sounds like a very good option 🤔
|
|
||
| use crate::entities::*; | ||
|
|
||
| #[cfg(test)] | ||
| use mockall::automock; | ||
|
|
||
| #[derive(Error, Debug)] | ||
| pub enum AggregatorHandlerError { |
| } | ||
| } | ||
|
|
||
| /// Unpack snapshot | ||
| async fn unpack_snapshot(&self, digest: &str) -> Result<String, String> { | ||
| async fn unpack_snapshot(&self, digest: &str) -> Result<String, AggregatorHandlerError> { |
There was a problem hiding this comment.
This seems to beg for a general utility to handle snapshot files for both packing and unpacking
There was a problem hiding this comment.
Absolutely, we definitely need to work shortly on a mithril-common library for all the general utilities such as the snapshotter 👍
jpraynaud
force-pushed
the
jpraynaud/147-client-verify-multi-signature
branch
from
338b079 to
971e4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a multi signature verifier for the Mithril Client
Closes #147