Skip to content

Replace "BFT nodes" with "Full nodes" in devnet #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2024
Merged

Replace "BFT nodes" with "Full nodes" in devnet #1642

merged 2 commits into from
Apr 22, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Apr 19, 2024 •
edited
Loading

Content

This PR includes some refactoring in the devnet.
BFT nodes are no longer used, replaced by Full nodes. The documentation and variable names have been adapted.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

Test Results

    3 files  ±0     43 suites  ±0   8m 21s ⏱️ +7s
  928 tests ±0    928 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 022 runs  ±0  1 022 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3337c61. ± Comparison against base commit d415b23.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview April 19, 2024 07:23 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 07:23 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Apr 19, 2024
View reviewed changes
@dlachaume dlachaume force-pushed the dlachaume/replace-bft-node-with-full-node-devnet branch 2 times, most recently from 176e7d5 to 98dd0dc Compare April 19, 2024 13:05
@dlachaume dlachaume marked this pull request as ready for review April 19, 2024 13:07
@dlachaume dlachaume self-assigned this Apr 19, 2024
@dlachaume dlachaume requested review from Alenar and sfauvel April 19, 2024 13:08
jpraynaud
jpraynaud approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume temporarily deployed to testing-preview April 19, 2024 13:13 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 19, 2024 13:13 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/replace-bft-node-with-full-node-devnet branch from 98dd0dc to 3337c61 Compare April 22, 2024 08:46
@dlachaume dlachaume temporarily deployed to testing-preview April 22, 2024 08:53 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet April 22, 2024 08:53 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 188d8b7 into main Apr 22, 2024
@dlachaume dlachaume deleted the dlachaume/replace-bft-node-with-full-node-devnet branch April 22, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud