Skip to content

Support Cardano 8.10.0 in testing-sanchonet #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2024
Merged

Support Cardano 8.10.0 in testing-sanchonet #1628

merged 4 commits into from
Apr 15, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Apr 10, 2024 •
edited
Loading

Content

This PR includes the support of Cardano node 8.10.0 for testing-sanchonet network.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1618

@jpraynaud jpraynaud self-assigned this Apr 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Test Results

    3 files  ±0     42 suites  ±0   9m 16s ⏱️ +28s
  914 tests ±0    914 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 008 runs  ±0  1 008 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ad2f765. ± Comparison against base commit 8725527.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview April 10, 2024 10:40 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet April 10, 2024 10:40 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/1618-upgrade-sanchonet-cardano-8.10 branch from 4bb8cd6 to ad2f765 Compare April 15, 2024 06:18
@jpraynaud jpraynaud requested review from Alenar and dlachaume April 15, 2024 06:18
@jpraynaud jpraynaud marked this pull request as ready for review April 15, 2024 06:18
@jpraynaud jpraynaud temporarily deployed to testing-preview April 15, 2024 06:25 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet April 15, 2024 06:25 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

@jpraynaud jpraynaud merged commit c4458db into main Apr 15, 2024
@jpraynaud jpraynaud deleted the jpraynaud/1618-upgrade-sanchonet-cardano-8.10 branch April 15, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@dlachaume dlachaume dlachaume approved these changes

+1 more reviewer

@sfauvel sfauvel sfauvel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare testing-sanchonet for respin with Cardano 8.10
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume