-
Notifications
You must be signed in to change notification settings - Fork 44
Implement Block range merkelization for Cardano transactions #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Block range merkelization for Cardano transactions #1560
Conversation
Test Results 3 files ± 0 42 suites ±0 8m 41s ⏱️ ±0s Results for commit dfbad9d. ± Comparison against base commit ffe19a9. This pull request removes 1 and adds 20 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
c1c607e
to
0257c98
Compare
4f029d4
to
e2c79bd
Compare
6359518
to
603252d
Compare
603252d
to
cb6aefc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a good job. Just a few comments.
7f0bd19
to
b4f962c
Compare
d78b993
to
8ade6ab
Compare
These data need to be updated as the transactions proof format has changed.
Also rollback from re-implementation with 'next_multiple_of' as it does not handle edge cases properly.
And use better namings for the list of transactions to prove.
And explain further the way MKMapNode work.
cdce1d2
to
94cab69
Compare
- 'mithril-aggregator' from '0.4.47' to '0.4.48' - 'mithril-client' from '0.6.7' to '0.6.8' - 'mithril-common' from '0.3.19' to '0.3.20'
94cab69
to
dfbad9d
Compare
Content
This PR includes the implementation of a merkelized map aka
MKMap
:keys
such asBlockRange
(also implemented in the PR) that implements theMKMapKey
traitvalues
such asMKMap
,MKTree
orMKTreeNode
(each represented as variants of aMKMapNode
enum which implements theMKMapValue
trait)MKMap
also allows to:equivalent
(i.e. same commitment) valuestrictly greater
than the existing keys) without recomputing completely the underlying Merkle treeMKTree
has also been enhanced:MKTreeStore
externallyInto<MKTreeNode>
instancesMKMap
and theMKTree
Benchmarks
Signature generation:
Proof generation:
Proof verification:
Pre-submit checklist
Issue(s)
Closes #1533