Skip to content

Fix signature related metrics name in signer #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Mar 5, 2024

Content

This PR includes the fix of a typo in the name of the signature related metrics in the signer.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Comments

Grafana dashboard need to be updated on the testing-preview and testing-sanchonet networks

Issue(s)

Relates to #1096

@jpraynaud jpraynaud self-assigned this Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Test Results

  3 files  ±0   42 suites  ±0   9m 0s ⏱️ +3s
909 tests ±0  909 ✅ ±0  0 💤 ±0  0 ❌ ±0 
998 runs  ±0  998 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0a50e1b. ± Comparison against base commit b1a0120.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview March 5, 2024 16:24 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet March 5, 2024 16:24 — with GitHub Actions Inactive
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud force-pushed the jpraynaud/1096-fix-signature-metrics-name branch from 42c6bd2 to 0a50e1b Compare March 5, 2024 17:06
@jpraynaud jpraynaud temporarily deployed to testing-preview March 5, 2024 17:18 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet March 5, 2024 17:18 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 1c6c5e6 into main Mar 6, 2024
@jpraynaud jpraynaud deleted the jpraynaud/1096-fix-signature-metrics-name branch March 6, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants