Skip to content

Fix clippy lint from rust 1.76 #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix clippy lint from rust 1.76 #1493

merged 2 commits into from
Feb 8, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Feb 8, 2024 •
edited
Loading

Content

This PR fix the clippy lints that are raised from the latest rust version (1.76)

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Alenar Alenar requested review from jpraynaud and dlachaume February 8, 2024 16:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

Test Results

  3 files  ±0   36 suites  ±0   8m 23s ⏱️ -6s
825 tests ±0  825 ✅ ±0  0 💤 ±0  0 ❌ ±0 
910 runs  ±0  910 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 00c59a1. ± Comparison against base commit 6cd739a.

@Alenar Alenar temporarily deployed to testing-preview February 8, 2024 16:44 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet February 8, 2024 16:44 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar merged commit 4c19373 into main Feb 8, 2024
@Alenar Alenar deleted the ensemble/rust_1-76 branch February 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @jpraynaud @dlachaume