Skip to content

Add dev blog post to announce Mithril client npm package #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add dev blog post to announce Mithril client npm package #1454

merged 2 commits into from
Jan 23, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 23, 2024 •
edited
Loading

Content

This PR includes:

  • A dev blog post to announce new Mithril client npm package publicly available
  • An update to the Mithril client WASM developer docs to remove mention to unpublished npm package

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

dlachaume
dlachaume approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, just two typos.

@jpraynaud jpraynaud force-pushed the ensemble/mithril-client-wasm-dev-blog-post branch from 65de487 to 8a2210c Compare January 23, 2024 14:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

Test Results

  3 files  ±0   33 suites  ±0   8m 49s ⏱️ - 2m 27s
760 tests ±0  760 ✅ ±0  0 💤 ±0  0 ❌ ±0 
833 runs  ±0  833 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 985fcb6. ± Comparison against base commit ed1b86d.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the ensemble/mithril-client-wasm-dev-blog-post branch from 8a2210c to 985fcb6 Compare January 23, 2024 15:00
@jpraynaud jpraynaud merged commit aace2ac into main Jan 23, 2024
@jpraynaud jpraynaud deleted the ensemble/mithril-client-wasm-dev-blog-post branch January 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@Alenar Alenar Awaiting requested review from Alenar

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpraynaud @dlachaume