Add DependencyManager Mithril Aggregator #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
changed the title
jpraynaud
force-pushed
the
ensemble/120-dependency-injection
branch
2 times, most recently
from
4827cc0 to
7a18e1f
Compare
* Implement a dependency manager * Add a snashot storer as a dependency * Use snapshot storer dependency in server routes
jpraynaud
force-pushed
the
ensemble/120-dependency-injection
branch
from
7a18e1f to
ee52d70
Compare
jpraynaud
changed the title
* Allow configuraton from json file or by env vars * Example launch when no config file: 'NETWORK=testnet URL_SNAPSHOT_MANIFEST=https://storage.googleapis.com/cardano-testnet/snapshots.json ./mithril-aggregator'
|
@abailly-iohk this new version embeds the We can configure the node with env vars now and run it with: How can we set these env vars in the end to end test of the CI? 🤔 |
|
There are various options, we could pass them to the process running |
|
Great, thanks 🙂 |
Alenar
approved these changes
Apr 22, 2022
Alenar
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a first version of a dependency manager that is accessed by the handlers of the http server of the aggregator