Skip to content

Use the cloud snapshots manifest in Mithril Aggregator #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

jpraynaud
Copy link
Member

Implementation of list_snapshots and use it in http handler snapshots with @Alenar.
Relates to #120

Next steps:

  • Implement get_snapshot_details and use it in http handler snapshot_digest
  • Enhance error output by using entities::Error
  • Inject dependency of a SnapshotStorer and use of a configuration file

@jpraynaud jpraynaud requested a review from a user April 15, 2022 14:21
@github-actions
Copy link

github-actions bot commented Apr 15, 2022

Unit Test Results

1 files  1 suites   1s ⏱️
5 tests 5 ✔️ 0 💤 0

Results for commit 6ecf689.

♻️ This comment has been updated with latest results.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bucket's name is likely to change and not reflect the network name but that's a good start!

@Alenar Alenar force-pushed the ensemble/aggregator-snapshot-store branch 2 times, most recently from aa7dd0f to 402a264 Compare April 20, 2022 07:39
jpraynaud and others added 2 commits April 20, 2022 09:50
Implementation of 'list_snapshots' and use it in http handler
A Quick & dirty implementation
@Alenar Alenar force-pushed the ensemble/aggregator-snapshot-store branch from 402a264 to 6ecf689 Compare April 20, 2022 07:50
@Alenar Alenar merged commit afb76e5 into main Apr 20, 2022
@Alenar Alenar deleted the ensemble/aggregator-snapshot-store branch April 20, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants