Skip to content

Add common error: CodecError #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2023
Merged

Add common error: CodecError #1193

merged 2 commits into from
Aug 31, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Aug 31, 2023 •
edited
Loading

Content

This PR includes a first implementation related to the error refactoring with the crate anyhow.
CodecError is raised when an encoding or decoding occurs.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #798

@dlachaume dlachaume changed the title Add new common error: CodecError Add common error: CodecError Aug 31, 2023
@dlachaume dlachaume force-pushed the ensemble/798/errors-refactoring branch from 8f52d21 to 94901f8 Compare August 31, 2023 09:06
jpraynaud
jpraynaud approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

Test Results

    3 files  ±0    17 suites  ±0   4m 49s ⏱️ -57s
671 tests ±0  671 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
727 runs  ±0  727 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit aa1de1e. ± Comparison against base commit 3673209.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview August 31, 2023 09:19 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the ensemble/798/errors-refactoring branch from 94901f8 to 863dab0 Compare August 31, 2023 09:20
@dlachaume dlachaume temporarily deployed to testing-preview August 31, 2023 09:29 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit c590faa into main Aug 31, 2023
@dlachaume dlachaume deleted the ensemble/798/errors-refactoring branch August 31, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlachaume @Alenar @jpraynaud