Skip to content

Fix network compatibility table generation #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix network compatibility table generation #1180

merged 1 commit into from
Aug 28, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Aug 28, 2023 •
edited
Loading

Content

This PR fix the network compatibility table generation: single quotes should have been used instead of double quotes.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1151, #1177

@github-actions
Copy link

Test Results

    3 files  ±0    17 suites  ±0   5m 59s ⏱️ + 1m 23s
671 tests ±0  671 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
727 runs  ±0  727 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8bd92d0. ± Comparison against base commit 393070a.

@Alenar Alenar temporarily deployed to testing-preview August 28, 2023 15:53 — with GitHub Actions Inactive
@Alenar Alenar merged commit 9e222f5 into main Aug 28, 2023
@Alenar Alenar deleted the djo/1151/fix-network_compatibility_table-in-releases branch August 28, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@dlachaume dlachaume dlachaume approved these changes

@jpraynaud jpraynaud Awaiting requested review from jpraynaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @ghubertpalo @dlachaume