Skip to content

Call Aggregator API to verify Signer registration #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Aug 22, 2023

Content

This PR includes an update of verify_signer_registration script.
It now calls /epoch-settings and/signers/registered/ to find out whether or not the signer is registered at the current epoch.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Run a Mithril signer as an SPO guide was updated for both versions (current & next).

Issue(s)

Closes #1152

@dlachaume dlachaume requested a review from Alenar August 22, 2023 09:54
@dlachaume dlachaume force-pushed the damien/1152/call-aggregator-api-to-verify-signer-registration branch from 8a3cdf7 to 8254aff Compare August 22, 2023 09:57
@dlachaume dlachaume force-pushed the damien/1152/call-aggregator-api-to-verify-signer-registration branch from 8254aff to 1b1d330 Compare August 22, 2023 10:41
@dlachaume dlachaume force-pushed the damien/1152/call-aggregator-api-to-verify-signer-registration branch from 1b1d330 to bbd4cc7 Compare August 22, 2023 12:28
@dlachaume dlachaume merged commit 45768aa into main Aug 22, 2023
@dlachaume dlachaume deleted the damien/1152/call-aggregator-api-to-verify-signer-registration branch August 22, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the /signers/registered route to verify if a signer is registered
2 participants