Skip to content

Fix broken .#hydraJobs.x86_64-linux.mithril-end-to-end #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

yvan-sraka
Copy link
Contributor

Content

This PR includes a quick fix to error: failed to create file /build/source/target/release/load-aggregator.d that happened in Hydra and was reproducible with nix build .#hydraJobs.x86_64-linux.mithril-end-to-end.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

This PR does fix the issue, but I'm not sure to understand fully the implications of the change. So reviews are welcome! :)

Issue(s)

N/A

error: failed to create file `/build/source/target/release/load-aggregator.d`
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

As someone not familiar with nix the only impact that I see is slower build since mithril-end-to-end won't reuse previously built artifacts for its mithril common & stm dependencies.

@Alenar Alenar merged commit f03bad9 into input-output-hk:main Aug 22, 2023
@angerman angerman assigned angerman and yvan-sraka and unassigned angerman Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants