-
Notifications
You must be signed in to change notification settings - Fork 44
StdResult and StdError as anyhow alias #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But also incorrectly to the dir with the same name.
b84f429
to
0daf3df
Compare
dlachaume
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
…lt whenever possible
0daf3df
to
bbf4ba9
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This heart of this PR is to change what
StdResult
andStdError
are aliasing to, replacing std types with the one fromanyhow
:Most of the other changes are related to adapting the code to
anyhow
results.This PR also:
StdResult
.This is an improvement since when main function yield an anyhow error, it is printed out nicely (including the backtrace, see this rust playground).
StdError
orStdResult
.Pre-submit checklist
Comments
The unused dependency to
lazy_static
frommithril-common
was removed. It was only used to access the.deref()
method something that the standard rust library already provide.Issue(s)
Relates to #798