Skip to content

ECS-3077 Apply style guide, tighten some sentences. #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2023
Merged

ECS-3077 Apply style guide, tighten some sentences. #1130

merged 2 commits into from
Aug 8, 2023

Conversation

NeilBurgess42
Copy link
Contributor

@NeilBurgess42 NeilBurgess42 commented Aug 3, 2023 •
edited by jpraynaud
Loading

Content

This PR includes a review of the protocol description in protocol.md

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to ECS-3077
Relates to #YYY or Closes #YYY

@Alenar Alenar requested a review from jpraynaud August 3, 2023 11:04
@Alenar Alenar added the documentation 📖 Documentation to add/update label Aug 3, 2023
@jpraynaud jpraynaud requested a review from olgahryniuk August 3, 2023 12:18
@olgahryniuk
Final editing tweaks
ab49fe2 
Changed titles to 'Sentence case' formatting
Some readability improvements
@olgahryniuk
Copy link
Collaborator

Committed some more improvements. Looks good, @NeilBurgess42 please mark the PR as 'ready for review'.
Over to @jpraynaud .
Thanks so much, everyone!

@NeilBurgess42 NeilBurgess42 marked this pull request as ready for review August 3, 2023 13:49
iquerejeta
iquerejeta approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Otherwise, LGTM

jpraynaud
jpraynaud approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

curiecrypt
curiecrypt approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@curiecrypt curiecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jpraynaud jpraynaud merged commit 8ae6f51 into input-output-hk:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iquerejeta iquerejeta iquerejeta approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@curiecrypt curiecrypt curiecrypt approved these changes

@olgahryniuk olgahryniuk Awaiting requested review from olgahryniuk

Assignees
No one assigned
Labels
documentation 📖 Documentation to add/update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NeilBurgess42 @olgahryniuk @jpraynaud @iquerejeta @curiecrypt @Alenar