Protocol key for Multi and Genesis signature #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Alenar
force-pushed
the
djo/668/protocol_key_for_multi_and_genesis_signature
branch
2 times, most recently
from
e6fe01c to
724ab94
Compare
Alenar
force-pushed
the
djo/668/protocol_key_for_multi_and_genesis_signature
branch
from
724ab94 to
463f798
Compare
|
I have a question regarding the Certificate hash computation that changed: |
No, as I said in the PR we are backward compatible, I made the changes to the hashes before migrating to ProtocolKeys (changes because of the updated Certificate structure). By the way the golden test for the certificate record was not impacted :). |
- In order to split them between "classic" and genesis certificate since the upcoming design won't allow to represent certificates that are both. - Add 'fake keys' for multi signatures & genesis signatures & use them were needed.
…nesis & multi-signature
A blanket implementation is available using the json hex format.
Alenar
force-pushed
the
djo/668/protocol_key_for_multi_and_genesis_signature
branch
from
463f798 to
fe7d24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR replace most use of hex encoded keys for multi & genesis signatures with a
ProtocolKeyon the concrete crypto type.In order to do so the
Certificateentity had to be adapted since it had two mutually excluding string fields (the exclusion was done manually without compiler help), one for the genesis the other for multi-signatures.This was done by adding a new type,
CertificateSignaturean enum with a variant for both cases.Since the genesis signature doesn't use the "json hex" encoding for serialization, contrary to all the previous types converted to a
ProtocolKey, theProtocolKeyadd to be modified to allow to change the inner encoding that it use.This was done with a new trait,
ProtocolKeyCodec, that define how aProtocolKeyis encoded or decoded to strings or to using serde.Pre-submit checklist
Comments
The hash changes were done before making the genesis & multi signatures into a protocol key (meaning that they did not changes afterward, ensuring backward compatibility), the changes were necessary because of the change to the Certificate structure.
Issue(s)
Relates to #668