Init Mithril Client #110
Merged
Init Mithril Client #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Apr 13, 2022
| @@ -148,6 +148,62 @@ jobs: | |||
| command: test | |||
| args: --release --manifest-path ./mithril-network/mithril-aggregator/Cargo.toml | |||
|
|
|||
| build-mithril-client: | |||
There was a problem hiding this comment.
Perhaps there's a way to have client and aggregator in the same project but as different exes or crates? That would speed things up and simplify build
There was a problem hiding this comment.
It's possible to have multiple binary built in a src/bin configuration of the project: this would allow us to build all executable files in the same job.
We can investigate further to see if it is a wise architectural choice 🤔
There was a problem hiding this comment.
I agree that it introduces coupling between the client and the aggregator via the datatypes, and it can lead down the road to hard-to-change code and deep dependencies, if we are not cautious about more dependencies to creep in.
jpraynaud
force-pushed
the
jpraynaud/mithril-client
branch
from
9a94c53 to
47a6e46
Compare
ghost
approved these changes
Apr 14, 2022
* Better handling of the configuration * Better separation between snapshot data and display * Separated the AggregatorHandler fake implementation to new file * Added 'show' snapshot subcommand
* Added publish artifacts in build Mithril Client job * Fixed cache issue in documentation job
jpraynaud
force-pushed
the
jpraynaud/mithril-client
branch
from
47a6e46 to
fd5a849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first version of the Mithril Client:
It is able to retrieve a list of snapshots from a Mithril Aggregator and display in the command line
cd mithril-network/mithril-aggregator && make debugcd mithril-network/mithril-client && make debug listRelates to #102