Skip to content

Enhance Run a Mithril Signer as an SPO guide #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 20, 2023

Content

This PR includes improvements of the guide "Run a Mithril Signer as an SPO". Examples have been added with the appropriate values for release-preprod network.

Two scripts have also been created to verify that the signer node is correctly configured and to check that it's correctly signing certificates. They are located in /docs/static/scripts/ directory.
A description of how to run them have been added at the end of the guide.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Closes #1055

@dlachaume dlachaume force-pushed the 1055/enhance-run-a-mithril-signer-node-guide branch 2 times, most recently from 2e5e2c5 to f5625eb Compare July 20, 2023 13:41
@jpraynaud jpraynaud marked this pull request as draft July 20, 2023 13:42
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments 🙂

@dlachaume dlachaume force-pushed the 1055/enhance-run-a-mithril-signer-node-guide branch 6 times, most recently from f2847cc to 969715b Compare July 25, 2023 14:51
@dlachaume dlachaume requested a review from jpraynaud July 25, 2023 15:39
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good!

Can you try to put the scripts in the docs folder for easier maintenance?

@dlachaume dlachaume force-pushed the 1055/enhance-run-a-mithril-signer-node-guide branch 6 times, most recently from 8648dfe to c09c28e Compare July 26, 2023 10:47
@dlachaume dlachaume requested a review from jpraynaud July 26, 2023 10:51
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments!

@dlachaume dlachaume force-pushed the 1055/enhance-run-a-mithril-signer-node-guide branch 2 times, most recently from 9f9ea23 to 056ffdd Compare July 26, 2023 16:03
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume marked this pull request as ready for review July 26, 2023 16:09
@dlachaume dlachaume force-pushed the 1055/enhance-run-a-mithril-signer-node-guide branch from 056ffdd to de037ee Compare July 27, 2023 09:04
@dlachaume dlachaume force-pushed the 1055/enhance-run-a-mithril-signer-node-guide branch from de037ee to dc74758 Compare July 27, 2023 09:16
@jpraynaud jpraynaud merged commit 75a4c4d into input-output-hk:main Jul 27, 2023
@dlachaume dlachaume deleted the 1055/enhance-run-a-mithril-signer-node-guide branch October 11, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Run a Mithril Signer node (SPO) guide
3 participants