-
Notifications
You must be signed in to change notification settings - Fork 44
Enhance Run a Mithril Signer as an SPO guide #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Run a Mithril Signer as an SPO guide #1071
Conversation
2e5e2c5
to
f5625eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments 🙂
f2847cc
to
969715b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good!
Can you try to put the scripts in the docs folder for easier maintenance?
8648dfe
to
c09c28e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments!
9f9ea23
to
056ffdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
056ffdd
to
de037ee
Compare
de037ee
to
dc74758
Compare
Content
This PR includes improvements of the guide "Run a Mithril Signer as an SPO". Examples have been added with the appropriate values for
release-preprod
network.Two scripts have also been created to verify that the signer node is correctly configured and to check that it's correctly signing certificates. They are located in
/docs/static/scripts/
directory.A description of how to run them have been added at the end of the guide.
Pre-submit checklist
Comments
None
Issue(s)
Closes #1055