Skip to content

Add run-only option in mithril-end-to-end test #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 13, 2023
Merged

Add run-only option in mithril-end-to-end test #1052

merged 6 commits into from
Jul 13, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 11, 2023 •
edited
Loading

Content

This PR includes the new option run-only for the command that launch the Mithril end-to-end test. It's behavior is described in the issue #1048.

It also includes another new option skip-cardano-bin-download which allows to use directly your cardano-cli & cardano-node binary files, skipping the download step from IOHK github repository.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

  • Add --run-only option to your command.
  • Add --skip-cardano-bin-download option to your command.

Issue(s)

Closes #1048

@dlachaume dlachaume force-pushed the 1048/add-run-only-option-in-end-to-end-test branch 8 times, most recently from a502545 to 2a5347c Compare July 12, 2023 17:48
jpraynaud
jpraynaud requested changes Jul 13, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to be done before it can be merged 🙂

@dlachaume dlachaume requested a review from jpraynaud July 13, 2023 10:18
jpraynaud
jpraynaud approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the 1048/add-run-only-option-in-end-to-end-test branch from 39d529a to 130ba4c Compare July 13, 2023 10:34
@jpraynaud jpraynaud merged commit 6c04aff into input-output-hk:main Jul 13, 2023
@dlachaume dlachaume deleted the 1048/add-run-only-option-in-end-to-end-test branch July 18, 2023 10:39
@dlachaume dlachaume mentioned this pull request Nov 7, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a run-only option in end to end test
2 participants
@dlachaume @jpraynaud