Skip to content

Add created_at field in Mithril Stake Distribution messages #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2023
Merged

Add created_at field in Mithril Stake Distribution messages #1047

merged 3 commits into from
Jul 11, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 10, 2023 •
edited
Loading

Content

This PR includes modifications in Mithril Stake Distribution messages. The field created_at was added in it.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

created_at field was already displayed in the explorer :

{mithrilStakeDistribution.created_at &&
    <ListGroup.Item>Created: {new Date(mithrilStakeDistribution.created_at).toLocaleString()}</ListGroup.Item>
}

in mithril-explorer/components/Artifacts/MithrilStakeDistributionsList/index.js

Issue(s)

Closes #1030

@dlachaume dlachaume force-pushed the 1030/add-created-at-in-mithril-stake-distribution-messages branch from c813bf9 to b996e0b Compare July 10, 2023 20:15
jpraynaud
jpraynaud approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just a typo to fix and upgrade versions

@dlachaume dlachaume force-pushed the 1030/add-created-at-in-mithril-stake-distribution-messages branch 2 times, most recently from 6a6bed6 to 8dc26cd Compare July 11, 2023 08:10
dlachaume added 2 commits July 11, 2023 10:11
@dlachaume
Add created_at field in the /mithril-stake-distributions route
0e955eb
@dlachaume
Fix message displays in explorer
207e256 
Replace 'snapshot' to 'mithril stake distribution' when Mithril Stake Distribution list is empty
@dlachaume dlachaume force-pushed the 1030/add-created-at-in-mithril-stake-distribution-messages branch from 8dc26cd to 207e256 Compare July 11, 2023 08:11
@dlachaume dlachaume requested a review from jpraynaud July 11, 2023 08:18
@jpraynaud jpraynaud requested review from Alenar and ghubertpalo July 11, 2023 08:58
jpraynaud
jpraynaud approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit 6a8511b into input-output-hk:main Jul 11, 2023
@dlachaume dlachaume deleted the 1030/add-created-at-in-mithril-stake-distribution-messages branch July 13, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add created_at in Mithril Stake Distribution messages
3 participants
@dlachaume @Alenar @jpraynaud