Skip to content

Remove certificate hash from Artifact #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 5, 2023
Merged

Remove certificate hash from Artifact #1027

merged 10 commits into from
Jul 5, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 3, 2023 •
edited
Loading

Content

This PR includes updates of Snapshot and MithrilStakeDistribution entities.

  • certificate_hash and created_at were removed in Snapshot entity
  • certificate_hash and created_at were removed in MithrilStakeDistribution entity
  • A migration was created to remove certificate_hash of artifact JSON in signed_entity table
  • MessageAdapter trait was splitted in FromMessageAdapter and ToMessageAdapter
  • Implement appropriate MessageAdapter trait for Mithril Client and Mithril Aggregator

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

FromMithrilStakeDistributionListAdapter and FromSnapshotListMessageAdapter adapters were removed since there are no longer used.

Issue(s)

Closes #932

@dlachaume dlachaume force-pushed the 932/remove-certificate-hash-from-artifact branch 3 times, most recently from 2ac7c2e to 47b8fa5 Compare July 4, 2023 13:38
@dlachaume dlachaume force-pushed the 932/remove-certificate-hash-from-artifact branch 3 times, most recently from ddbe784 to cb72d74 Compare July 5, 2023 08:57
@dlachaume dlachaume force-pushed the 932/remove-certificate-hash-from-artifact branch from cb72d74 to e493206 Compare July 5, 2023 08:58
jpraynaud
jpraynaud approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I left few comments to fix before merging

@jpraynaud jpraynaud merged commit d357e91 into input-output-hk:main Jul 5, 2023
@dlachaume dlachaume deleted the 932/remove-certificate-hash-from-artifact branch July 13, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar left review comments

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove certificate hash from Artifact
3 participants
@dlachaume @Alenar @jpraynaud