Skip to content

Use cargo-nextest to run test on CI and reenable tests report #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jun 29, 2023

Content

This PR changes the runner that are used for tests in CI to cargo-nextest. This give the following benefits :

  • Re-enable tests reports in our PR using nextest junit support without the need of cargo2junit and unstable cargo features.
  • Faster tests because of nextest execution model being more aggressive with parallelization (ie: integration tests can run in parallel of units test).

This PR also changes the way third party cargo tools are retrieved in the CI: instead of using cargo install that retrieve the tool source and compile them (making our github caches heavier) we now use cargo binstall to retrieve precompiled binaries.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #978

@Alenar Alenar force-pushed the djo/978/cargo-nextest-in-ci branch from 88dca34 to 22cdf02 Compare June 29, 2023 13:06
@Alenar Alenar force-pushed the djo/978/cargo-nextest-in-ci branch 2 times, most recently from a4f3fcb to 3db1aa2 Compare June 29, 2023 13:45
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Test Results

    3 files    16 suites   5m 25s ⏱️
607 tests 607 ✔️ 0 💤 0
647 runs  647 ✔️ 0 💤 0

Results for commit 754771c.

♻️ This comment has been updated with latest results.

@Alenar Alenar force-pushed the djo/978/cargo-nextest-in-ci branch 3 times, most recently from 439d00d to 95f7411 Compare June 29, 2023 14:27
@Alenar Alenar temporarily deployed to testing-preview June 29, 2023 14:35 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/978/cargo-nextest-in-ci branch from 95f7411 to 1f28647 Compare June 29, 2023 14:38
@Alenar Alenar temporarily deployed to testing-preview June 29, 2023 14:46 — with GitHub Actions Inactive
@Alenar Alenar requested review from jpraynaud and ghubertpalo June 29, 2023 14:47
@Alenar Alenar force-pushed the djo/978/cargo-nextest-in-ci branch from 1f28647 to 6133bb8 Compare June 29, 2023 15:02
@Alenar Alenar temporarily deployed to testing-preview June 29, 2023 15:10 — with GitHub Actions Inactive
@Alenar Alenar marked this pull request as ready for review June 29, 2023 15:10
+ Build tests in a dedicated step to remove build outputs from tests
  run.
+ fetch cargo tools using cargobinstall to get precompiled binaries
  instead of compiling them (this will also reduce our cache size °°).
+ Reenable tests reports in CI using junit reports generated by
  cargo-nextest.
@Alenar Alenar force-pushed the djo/978/cargo-nextest-in-ci branch from 6133bb8 to 754771c Compare June 29, 2023 15:21
@Alenar Alenar temporarily deployed to testing-preview June 29, 2023 15:29 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar merged commit 69c34d7 into main Jun 29, 2023
@Alenar Alenar deleted the djo/978/cargo-nextest-in-ci branch June 29, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactivate Publish Results job in CI
2 participants