Skip to content

nix: bump crane to fix build. Add basic hydraJobs. #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

nix: bump crane to fix build. Add basic hydraJobs. #1002

merged 1 commit into from
Jun 22, 2023

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Jun 21, 2023 •
edited
Loading

Content

Currently main nix build fails with

error: failed to remove file /build/source/target/release/crane-dummy

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@jbgi jbgi self-assigned this Jun 21, 2023
jpraynaud
jpraynaud approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jbgi jbgi temporarily deployed to testing-preview June 21, 2023 15:39 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit d1fe374 into main Jun 22, 2023
@jpraynaud jpraynaud deleted the jbgi/nix-fixes branch June 22, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@jbgi jbgi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbgi @jpraynaud