Etcm 52 make sure mantis works on windows #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapke
force-pushed
the
etcm-52-make-sure-mantis-works-on-windows
branch
from
8ba58a3 to
661d333
Compare
kapke
requested review from
mirkoAlic,
KonradStaniec and
ntallar
and removed request for
mirkoAlic
ntallar
requested changes
Sep 16, 2020
| @@ -510,7 +510,7 @@ trait GenesisDataLoaderBuilder { | |||
|
|
|||
| trait SecureRandomBuilder { | |||
| lazy val secureRandom: SecureRandom = | |||
| Config.secureRandomAlgo.map(SecureRandom.getInstance).getOrElse(new SecureRandom()) | |||
| Config.secureRandomAlgo.flatMap(name => Try(SecureRandom.getInstance(name)).toOption).getOrElse(new SecureRandom()) | |||
There was a problem hiding this comment.
Doesn't this hide the fact that the selected algorithm is available and other one is instead being used?
There was a problem hiding this comment.
If I add logging about algorithm non available, will it be sufficient?
There was a problem hiding this comment.
Yes, given our current handling of config errors I think that with logging with error will be enough here
KonradStaniec
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
I had run mantis on macos, from pre-exsiting database and it seems to work fine. @kapke did you check it on windows ?
|
I did, whole PR was prepared on Windows machine |
kapke
force-pushed
the
etcm-52-make-sure-mantis-works-on-windows
branch
2 times, most recently
from
6a08ed2 to
811f3d7
Compare
kapke
force-pushed
the
etcm-52-make-sure-mantis-works-on-windows
branch
from
952a4f9 to
02510ad
Compare
kapke
force-pushed
the
etcm-52-make-sure-mantis-works-on-windows
branch
from
02510ad to
f270dac
Compare
ntallar
approved these changes
Sep 17, 2020
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues found when trying to run Mantis on Windows, that is:
.batfilesSecureRandominstance is obtainedTesting
All tests,
sbt distand syncing from both sbt and dist package should work