[ETCM-1015] Add Magneto block height to configs #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-golebiewski
force-pushed
the
feature/etcm-1015
branch
2 times, most recently
from
f96f24d to
d81e4e7
Compare
lukasz-golebiewski
force-pushed
the
feature/etcm-1015
branch
from
d81e4e7 to
3232cf2
Compare
lukasz-golebiewski
requested review from
dzajkowski,
AurelienRichez and
strauss-m
AurelienRichez
approved these changes
Jul 16, 2021
| @@ -224,28 +224,12 @@ class BlockGeneratorSpec extends AnyFlatSpec with Matchers with ScalaCheckProper | |||
| gasTieBreaker = false, | |||
| ethCompatibleStorage = true, | |||
| treasuryAddress = Address(0), | |||
| forkBlockNumbers = ForkBlockNumbers( | |||
| forkBlockNumbers = ForkBlockNumbers.Empty.copy( | |||
strauss-m
approved these changes
Jul 16, 2021
| @@ -98,6 +98,10 @@ | |||
| # https://ecips.ethereumclassic.org/ECIPs/ecip-1099 | |||
| ecip1099-block-number = "1000000000000000000" | |||
|
|
|||
| # Magneto EVM and Protocol Upgrades | |||
| # https://ecips.ethereumclassic.org/ECIPs/ecip-1103 | |||
| magneto-block-number = "1000000000000000000" | |||
There was a problem hiding this comment.
Instead of using a super high block number, why not define this config value as Option[BigInt], and omit it in the files where it does not make sense?
There was a problem hiding this comment.
I was thinking about doing it like this, but in the end didn't to remain consistent. Perhaps it would make sense to refactor those configs with the approach above in a separate PR?
There was a problem hiding this comment.
There is a configuration added by me, that is an Option already :) So total consistency is already gone 😅
I would love to see this refactored
dzajkowski
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Magneto block height to the app's config files