This repository was archived by the owner on Jun 17, 2020. It is now read-only.
Buildkite: fix NIX_PATH and add deployment key for haskell.nix #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the default value of NIX_PATH.
rvl
added a commit
to input-output-hk/haskell.nix
that referenced
this pull request
Mar 20, 2019
rvl
added a commit
to input-output-hk/haskell.nix
that referenced
this pull request
Mar 20, 2019
angerman
approved these changes
Mar 20, 2019
Contributor
angerman
left a comment
angerman
left a comment
There was a problem hiding this comment.
👍
Is there anyway one could exfil this key?
Contributor
Author
Yes, a buildkite build could |
Contributor
Should we prevent buildkite to run on untrusted PRs then? |
Contributor
Author
Yes. Already, Buildkite will not run PR builds from users who don't have repo write access. |
Contributor
Author
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 21, 2019
549: Buildkite: fix NIX_PATH and add deployment key for haskell.nix r=rvl a=rvl Fix problems found when doing input-output-hk/haskell.nix#93. Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Contributor
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problems found when doing input-output-hk/haskell.nix#93.