Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unit id for package key #2239

Merged
merged 97 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
3e1c1b9
Add available targets to plan.json
hamishmack Aug 9, 2024
1bf543c
update nix-tools-static.nix
Aug 9, 2024
329548e
Use unit id for package key
hamishmack Aug 9, 2024
0d6d9e5
Update overlays/haskell.nix
hamishmack Aug 9, 2024
5d8a9ad
Rename plan-json projectNix
hamishmack Aug 9, 2024
db0a77a
Source location fixes
hamishmack Aug 10, 2024
83db180
Fix projects not in sub dir
hamishmack Aug 10, 2024
02edb82
Add `identifier` and `checks` to `hsPkgs.${pkg-name}`
hamishmack Aug 12, 2024
baad5ae
Fix setup dependencies
hamishmack Aug 12, 2024
f01d23c
Enable component overrides by package name
hamishmack Aug 13, 2024
185b40e
Fix for building iserv-proxy
hamishmack Aug 13, 2024
bf4b6f2
Add support for package level overrides
hamishmack Aug 13, 2024
77431cc
Disable aarch64-linux on hydra
hamishmack Aug 13, 2024
9014e6e
Fix more override types
hamishmack Aug 14, 2024
2758551
Support for overriding package src
hamishmack Aug 14, 2024
c9ffefb
Support for overriding package src
hamishmack Aug 14, 2024
d83e2df
Try using unsafeDiscardStringContext
hamishmack Aug 15, 2024
5d4bcd8
Fix absolute paths
hamishmack Aug 15, 2024
d91fcf0
Fix absolute paths
hamishmack Aug 15, 2024
f7f06b3
Library component may not have exe-depends
hamishmack Aug 15, 2024
bf06758
More fixes
hamishmack Aug 16, 2024
a242292
Don't set values for pre-existing packages
hamishmack Aug 16, 2024
081da23
disable macOS for now
hamishmack Aug 16, 2024
d3f35cb
Fix for cross compilation
hamishmack Aug 16, 2024
cfe3bf2
Revert "disable macOS for now"
hamishmack Aug 16, 2024
278df11
Per component pre-exisiting depends
hamishmack Aug 19, 2024
c69b53f
Fix handling of buildable: False
hamishmack Aug 19, 2024
7595b61
Add `pre-existing` to component module
hamishmack Aug 19, 2024
f7adf1a
Fix path logic
hamishmack Aug 19, 2024
144ee20
Use pkgsBuildBuild for setup.depends
hamishmack Aug 19, 2024
52ff297
Update overlays/haskell.nix
hamishmack Aug 19, 2024
89a13e8
Update overlays/haskell.nix
hamishmack Aug 19, 2024
f5f959a
Fix using wrong .cabal file
hamishmack Aug 20, 2024
9133141
Fix th-dlls-minimal test
hamishmack Aug 20, 2024
59ff888
Fix callCabalProjectToNix test
hamishmack Aug 20, 2024
c04191e
fix cabal-hpack tests
hamishmack Aug 21, 2024
a9fd2b6
fix cabal-hpack tests
hamishmack Aug 21, 2024
4e6a7d5
Fix source repo subdir
hamishmack Aug 23, 2024
a25b0c2
Fix hackage revisions
hamishmack Aug 23, 2024
a3380ae
Fix hackage revisions
hamishmack Aug 23, 2024
b68279a
Fix TH compilation for GHCJS
hamishmack Aug 26, 2024
0b332f8
Fix hydra eval error
hamishmack Aug 26, 2024
637a6b8
Fix `with-packages` test
hamishmack Aug 27, 2024
88ed729
Fix package level component options
hamishmack Aug 27, 2024
f15cebc
Leave out `ghc-boot-packages`
hamishmack Aug 30, 2024
7c7b937
Merge remote-tracking branch 'origin/master' into hkm/use-plan-json
hamishmack Aug 30, 2024
27cc10a
Pass null for hsPkgs when it is not needed
hamishmack Aug 30, 2024
ea77ac0
Fixes for ghcjs 8.10.7
hamishmack Aug 31, 2024
aa50765
Fix "Multiple versions for Win32"
hamishmack Aug 31, 2024
c45c70f
Fixes for ghcjs 8.10.7
hamishmack Sep 2, 2024
cdc0caf
Fix coverage reports
hamishmack Sep 3, 2024
ab35f48
Include pre-existing, libs, pkgconfig and frameworks for shell
hamishmack Sep 3, 2024
b197a5a
Include pre-existing, libs, pkgconfig and frameworks for shell
hamishmack Sep 3, 2024
4138a45
Add identifier.id defaultText
hamishmack Sep 3, 2024
3f721cf
Merge remote-tracking branch 'origin/master' into hkm/use-plan-json
hamishmack Sep 3, 2024
ce1a3fc
Use `mkAliasDefinitions` to copy package overrides
hamishmack Sep 3, 2024
55b8a42
Add missing package keys
hamishmack Sep 3, 2024
d07d99b
Fix githash test
hamishmack Sep 3, 2024
2ada9c4
Update modules/plan.nix
hamishmack Sep 3, 2024
4cec161
Fix subDir
hamishmack Sep 4, 2024
38c25f2
Fix logic for detecting cabal-doctest
hamishmack Sep 4, 2024
5b12bd8
Fix logic for detecting cabal-doctest
hamishmack Sep 4, 2024
ceab542
Fix logic for detecting cabal-doctest
hamishmack Sep 4, 2024
b95d648
Remove os-string flag workaround that should not be needed any more
hamishmack Sep 5, 2024
905f598
Try without ghcjs overrides for pre-existing package (might not be ne…
hamishmack Sep 5, 2024
c658644
Try to fix js-template-haskell test
hamishmack Sep 5, 2024
c47949d
Add ghci for ghcjs to test/cabal.project.local
hamishmack Sep 5, 2024
495cae2
Fix ghc-lib-parser-8.10.7.20220219
hamishmack Sep 5, 2024
17aabb8
Simpler fix for ghc-lib-parser
hamishmack Sep 6, 2024
ae34d8a
Merge remote-tracking branch 'origin/master' into hkm/use-plan-json
hamishmack Sep 6, 2024
1254ba4
Use new `time` with GHC HEAD
hamishmack Sep 6, 2024
0c1fdfc
Move modules for using `plan.json` `install-plan` into separate files.
hamishmack Sep 6, 2024
8fa0abb
Fix setting of `planned` flag
hamishmack Sep 6, 2024
4cb4268
Update hydra eval checks
hamishmack Sep 8, 2024
0fddc58
Use pinned tools for check-hydra
hamishmack Sep 9, 2024
e46398c
Use pinned tools for check-hydra
hamishmack Sep 9, 2024
9c28621
Add allowed-uris arg
hamishmack Sep 9, 2024
b3f567a
Add allowed-uris arg
hamishmack Sep 9, 2024
ffd40a3
Add materialized file needed for cross platform eval
hamishmack Sep 9, 2024
7b3b449
Add comments
hamishmack Sep 9, 2024
1257535
Remove unused binding
hamishmack Sep 9, 2024
a479589
Add loadCabalPlan function
hamishmack Sep 9, 2024
c73c30e
Skip darwin when testing hydra eval in github action
hamishmack Sep 9, 2024
b2829bb
Fix hydra eval github action
hamishmack Sep 9, 2024
6a431ff
Merge remote-tracking branch 'origin/master' into hkm/use-plan-json
hamishmack Sep 9, 2024
4b6ad33
Leave redirects out of `allHsPkgsComponents`
hamishmack Sep 10, 2024
0b10d7a
Include hsPkgs."${name}-${version}"
hamishmack Sep 10, 2024
47a3191
Merge remote-tracking branch 'origin/master' into hkm/use-plan-json
hamishmack Sep 11, 2024
489b333
Merge remote-tracking branch 'origin/master' into hkm/use-plan-json
hamishmack Sep 12, 2024
5109ce5
Add `buildType` and `setup` to `hsPkgs` redirects
hamishmack Sep 12, 2024
7f79219
Add change log entry
hamishmack Sep 16, 2024
181931b
Merge remote-tracking branch 'origin/master' into hkm/use-plan-json
hamishmack Sep 16, 2024
8356b9d
Update change log entry
hamishmack Sep 16, 2024
6127a31
Update change log entry
hamishmack Sep 16, 2024
b0182bb
Avoid running githash test on every commit
hamishmack Sep 16, 2024
2c2ecb4
Merge remote-tracking branch 'origin/master' into hkm/use-plan-json
hamishmack Sep 17, 2024
b6b8c46
Avoid running githash test on every commit
hamishmack Sep 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix TH compilation for GHCJS
  • Loading branch information
hamishmack committed Aug 26, 2024
commit b68279ad7f1e7d83b1e4b6b40227aa6ebeee35fd
3 changes: 1 addition & 2 deletions builder/make-config-files.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
let
# Sort and remove duplicates from nonReinstallablePkgs.
# That way changes to the order of nonReinstallablePkgs does not require rebuilds.
nonReinstallablePkgs' = __attrNames (lib.genAttrs nonReinstallablePkgs (x: x))
++ component.pre-existing or [];
nonReinstallablePkgs' = __attrNames (lib.genAttrs (component.pre-existing ++ nonReinstallablePkgs) (x: x));

ghc = if enableDWARF then defaults.ghc.dwarf else defaults.ghc;

Expand Down
10 changes: 7 additions & 3 deletions overlays/haskell.nix
Original file line number Diff line number Diff line change
Expand Up @@ -774,9 +774,13 @@ final: prev: {
};
}) plan-json.install-plan);
});
modules = [{
preExistingPkgs = [];
}
modules = [({config, pkgs, ...}: {
nonReinstallablePkgs = ["rts"] ++ final.lib.optionals (pkgs.stdenv.hostPlatform.isGhcjs) ([
# ghci and its dependencies
"ghci" "binary" "bytestring" "containers" "template-haskell" "array" "deepseq" "filepath" "ghc-boot" "ghc-boot-th" "ghc-heap" "transformers" "unix" "directory" "time" "ghc-platform" "os-string"
] ++ final.lib.optionals (builtins.compareVersions config.compiler.version "8.11" < 0) [
"ghcjs-prim" "ghcjs-th"]);
})
({config, ...}: {
packages = final.lib.listToAttrs (map (p: {
name = to-key p;
Expand Down
Loading