Skip to content

Conversation

@angerman
Copy link
Collaborator

@angerman angerman commented Jul 14, 2019

Fixes #201, #191

@angerman
Copy link
Collaborator Author

This will sadly cause a mass-rebuild. Let's see what breaks!

@angerman
Copy link
Collaborator Author

Ok, this just won't work for now as cabal screws with sublibs. It seems to be impossible to get exact-configuration + cabal_config to work with sublibs. I'll bang my head against this a bit more, but may give up.

@angerman angerman marked this pull request as ready for review July 16, 2019 05:00
@angerman angerman requested review from michaelpj and rvl and removed request for rvl July 16, 2019 05:00
@angerman angerman self-assigned this Jul 16, 2019
@angerman angerman changed the title Better defaults (doExactConfig = true; doHaddock = false; non-reinstallable lib:ghc) Better defaults (doExactConfig = true; doHaddock = true; non-reinstallable lib:ghc) Jul 16, 2019
@angerman
Copy link
Collaborator Author

@rvl convinced me that we do want haddocks to be the default.

@angerman angerman merged commit 8a3489e into master Jul 16, 2019
@angerman angerman deleted the angerman/fix-201 branch July 16, 2019 07:15
@klarkc
Copy link

klarkc commented Oct 5, 2023

@angerman what was the argument? Just to see if worth it to keep it enabled (it doubles the number of building packages here).

@angerman
Copy link
Collaborator Author

angerman commented Oct 5, 2023

@klarkc I'm afraid I don't completely recall the argument anymore. I think it was due to haddocks not being available at when disabled.

Do you have a specific reason for the inverse default?

@klarkc
Copy link

klarkc commented Oct 5, 2023

@angerman no specific reason, just trying to optimize build times.

@angerman
Copy link
Collaborator Author

angerman commented Oct 6, 2023

To optimize buildtimes cur everything you don't absolutely need :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better defaults (doExactConfig = true; doHaddock = false; non-reinstallable lib:ghc)

3 participants