Switch to enableNativeBignum = true when available #1783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjm
force-pushed
the
enable-native-bignum
branch
from
b732cf8 to
2e8ae5c
Compare
|
bors try |
tryBuild failed: |
|
Moved to #1784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion on #1254. CC @hamishmack
AFAICT the current code is backwards -- it checks native bignum is possible, and if so it passes
enableNativeBignum = false. This PR flips it the other way.I've built my project's static executable with this and it seems to work fine. I'm not sure how to tell if a static executable is built using native bignum though.
EDIT: actually, I think it works! I tried building my executable with dynamic linking, both with and without this change. When I build with this change, the
libgmpdependency disappears!