Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a bad hack even worse; but maybe more performant.
Ok, so the whole code in the relevant linker is fairly bad. We set
MAP_LOW_MEM
ifaarch64_HOST_ARCH
; or ifMAP_32BIT
is set.If
MAP_LOW_MEM
is defined we definemmap_again
. If not it's not even there... there is still some rather odd logic, which likely won't work in some#elif
clause, which refers tommap_again
. This is, I believe the whole reason why this thing simply doesn't work properly. But fixing it proper is more involved than just doing this here.The whole blinker logic needs to be redone really.