Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LW-12086] fix: libiconv.dylib issue on previous macOS #3268

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Jan 8, 2025

LW-12086

See #3263.

See https://forum.cardano.org/t/daedalus-version-7-not-opening-on-mac-mac-os-x-10-15-7-after-install/141116.

Numerous users reported this when running on non-latest macOS:

Application Specific Information:
dyld: launch, loading dependent libraries

Dyld Error Message:
  Library not loaded: @executable_path/libcharset.1.dylib
  Referenced from: /Applications/Daedalus Mainnet.app/Contents/MacOS/libiconv.dylib
  Reason: Incompatible library version: libiconv.dylib requires version 2.0.0 or later, but libcharset.1.dylib provides version 1.0.0

Todos

n/a

Screenshots

n/a

Testing Checklist

n/a

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus
Copy link
Member Author

@kirk-bit, could you please test this build? 🙏

It's not yet notarized, I'm waiting for some legal approval, but you can:

  1. Scroll down to "Checks" in this PR.
  2. Go to the Buildkite build – https://buildkite.com/input-output-hk/daedalus/builds/23426
  3. Unfold daedalus-x86_64-darwin.
  4. Select the Artifacts tab.
  5. And download the Mainnet build: https://ci-output-sink.s3.amazonaws.com/csl-daedalus/daedalus-7.0.2-72405-mainnet-039a1c9c0-x86_64-darwin.pkg

Because it's not notarized, you will have to RightClick+Open it to bypass the notarization check.

Or you can wait a little for legal, but I can’t guarantee when it is available notarized. 🐌

@michalrus michalrus changed the title fix: libiconv.dylib issue on previous macOS [LW-12086] fix: libiconv.dylib issue on previous macOS Jan 9, 2025
@michalrus
Copy link
Member Author

@kirk-bit I have a better link – fully notarized, and stapled, and hopefully working on Big Sur – could you test it?

daedalus-7.0.2-72456-mainnet-234dcc076-x86_64-darwin.pkg

@michalrus michalrus changed the base branch from develop to release/7.1.0 January 10, 2025 15:44
@michalrus michalrus merged commit 41423f8 into release/7.1.0 Jan 10, 2025
3 of 5 checks passed
@michalrus michalrus deleted the fix/previous-macos branch January 10, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant