-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1203] Define a proxy for currency conversions #3121
Conversation
c71d35c
to
f822f1a
Compare
f822f1a
to
eb72279
Compare
@michalrus do we want to use |
@marcin-mazurek yes, I agree! I thought we might change the domain after QA approves this, which will allow Gytis to set up a production environment. Maybe we should then run just a quick QA test with the updated domain ? |
@michalrus perfect, that was my understanding, I'll just add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work @michalrus 👍
This PR defines an OCI container which serves as a proxy for our currency conversions
Todos
Screenshots
n/a
Testing Checklist
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersrun Chromatic
label to PR to trigger the run)release-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review