Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-1203] Define a proxy for currency conversions #3121

Merged
merged 7 commits into from
May 17, 2023

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented May 9, 2023

This PR defines an OCI container which serves as a proxy for our currency conversions

Todos

Screenshots

n/a

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus michalrus force-pushed the chore/ddw-1203-currency-proxy branch from f822f1a to eb72279 Compare May 9, 2023 17:02
Base automatically changed from chore/ddw-1083-flakes to develop May 11, 2023 09:51
@michalrus michalrus requested review from a team May 16, 2023 10:12
@marcin-mazurek
Copy link
Contributor

@michalrus do we want to use dev-preprod instance for production, or is it for testing purposes, to give @gytis-ivaskevicius an OK from our side? Although I appreciate the network assignment is artificial in this case, I think for actual production builds we shouldn't use anything that has dev in its name, since it might not be stable enough

@michalrus
Copy link
Member Author

@marcin-mazurek yes, I agree! I thought we might change the domain after QA approves this, which will allow Gytis to set up a production environment. Maybe we should then run just a quick QA test with the updated domain ?

@marcin-mazurek
Copy link
Contributor

@michalrus perfect, that was my understanding, I'll just add DO NOT MERGE label to avoid confusion.

@ManusMcCole ManusMcCole self-requested a review May 16, 2023 19:05
@michalrus michalrus requested a review from gabriela-ponce May 17, 2023 10:36
@miorsufianiohk miorsufianiohk self-requested a review May 17, 2023 10:44
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @michalrus 👍

@marcin-mazurek marcin-mazurek merged commit 86f0d1d into develop May 17, 2023
@michalrus michalrus deleted the chore/ddw-1203-currency-proxy branch May 17, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants