Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❤️ Add members of Cardano Wallet team to the "About Daedalus" screen. #3092

Conversation

jonathanknowles
Copy link
Member

@jonathanknowles jonathanknowles commented Dec 27, 2022

Hi there!

The "About Daedalus" screen includes some members of the Cardano Wallet developer team, but some are missing. I wonder if it's possible to add the remaining members? 🙏🏻 (I've added them in this PR.)

The following members are already listed within the "Cardano Team" section:

This PR adds the remaining (current) members to the same section:

Many thanks! 🎄

Jonathan

@tomislavhoracek
Copy link
Contributor

cc @danielmain @daniloprates

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/add-cardano-wallet-team branch 3 times, most recently from e967ec8 to d3f697c Compare January 12, 2023 02:13
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/add-cardano-wallet-team branch 4 times, most recently from 3c3d9f3 to 2ed1eee Compare January 18, 2023 08:08
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/add-cardano-wallet-team branch from 2ed1eee to f3f0aaa Compare March 28, 2023 02:59
@piotr-iohk piotr-iohk requested a review from danielmain June 1, 2023 11:59
@jonathanknowles jonathanknowles removed their assignment Jun 1, 2023
@piotr-iohk
Copy link

Please approve and make our children, wives and girlfriends happy and proud... 🙏

@Unisay
Copy link

Unisay commented Jun 1, 2023

s/Yura Lazarev/Yuriy Lazaryev/ please:)

@jonathanknowles jonathanknowles force-pushed the jonathanknowles/add-cardano-wallet-team branch from fbd2a04 to 70474b6 Compare June 2, 2023 06:31
@jonathanknowles
Copy link
Member Author

Yuriy Lazaryev

@Unisay Apologies for using the wrong spelling here. -- I've now updated it! Could you verify that the new spelling is correct? 🙏🏻

This commit adds the following members of the Cardano Wallet developer team:

- Heinrich Apfelmus
- Jonathan Knowles
- Paolo Veronelli
- Yuriy Lazaryev

The following members are already listed:

- Johannes Lund
- Pawel Jakubas
- Piotr Stachyra

The existing alphabetical order is retained.
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/add-cardano-wallet-team branch from 70474b6 to 64a3d82 Compare June 2, 2023 06:38
@jonathanknowles jonathanknowles changed the title Add members of Cardano Wallet team to the "About Daedalus" screen. Add members of Cardano Wallet team to the "About Daedalus" screen. ❤️ Jun 2, 2023
@jonathanknowles jonathanknowles changed the title Add members of Cardano Wallet team to the "About Daedalus" screen. ❤️ ❤️ Add members of Cardano Wallet team to the "About Daedalus" screen. Jun 2, 2023
@jonathanknowles
Copy link
Member Author

cc @marcin-mazurek

@marcin-mazurek marcin-mazurek self-assigned this Jun 14, 2023
@marcin-mazurek marcin-mazurek self-requested a review June 14, 2023 08:20
@miorsufianiohk miorsufianiohk self-requested a review June 14, 2023 11:54
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job @jonathanknowles 👍

@tomislavhoracek
Copy link
Contributor

Please add a CHANGELOG entry 🙏

Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@marcin-mazurek marcin-mazurek merged commit a22c045 into input-output-hk:develop Jun 14, 2023
@jonathanknowles jonathanknowles deleted the jonathanknowles/add-cardano-wallet-team branch June 15, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants