Skip to content

feat(rust/cbork): Add deterministically decoding array #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Jul 8, 2025

Description

  • Added deterministically decoding array to cbork-utils without recursively checking each element

Related Issue(s)

Closes #397

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Jul 8, 2025
@apskhem apskhem added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Jul 8, 2025
@apskhem apskhem added this to Catalyst Jul 8, 2025
@apskhem apskhem changed the title feat(rust/cbork): Add deterministically decoding array [WIP] feat(rust/cbork): Add deterministically decoding array Jul 8, 2025
@apskhem apskhem changed the title [WIP] feat(rust/cbork): Add deterministically decoding array feat(rust/cbork): Add deterministically decoding array [WIP] Jul 8, 2025
@apskhem apskhem changed the base branch from main to feat/new-cat-signed-doc July 8, 2025 12:31
@apskhem apskhem added the review me PR is ready for review label Jul 9, 2025
@apskhem apskhem changed the title feat(rust/cbork): Add deterministically decoding array [WIP] feat(rust/cbork): Add deterministically decoding array Jul 9, 2025
@apskhem apskhem moved this from New to 👀 In review in Catalyst Jul 9, 2025
@apskhem apskhem requested a review from Mr-Leshiy July 9, 2025 08:00
@apskhem apskhem added the rr: gatekeepers Required review by gatekeepers team label Jul 9, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Test Report | ${\color{lightgreen}Pass: 385/385}$ | ${\color{red}Fail: 0/385}$ |

@apskhem apskhem requested a review from Mr-Leshiy July 9, 2025 10:12
@apskhem apskhem moved this from 🔖 Ready to 👀 In review in Catalyst Jul 9, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apskhem apskhem merged commit 7d9a6bd into feat/new-cat-signed-doc Jul 9, 2025
39 of 43 checks passed
@apskhem apskhem deleted the feat/deterministic-cbor-array-decoder branch July 9, 2025 12:24
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review rr: gatekeepers Required review by gatekeepers team squad: gatekeepers Catalyst App Backend, System Development & Integration Team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CBOR deterministically decoded Array type
3 participants