Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleans up eventdb entrypoint and adds fix for RDS | NPG-000 #690

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

jmgilman
Copy link
Collaborator

@jmgilman jmgilman commented Apr 9, 2024

This PR addresses the following issues:

  1. We no longer have a dependency on graphql, so it removes all init code related to that in the eventdb entrypoint
  2. The entrypoint was trying to connect to a database that didn't exist
    a. It was changed to connect to the "root" database on initialization (a new input was added for this)
  3. For initialization to work with RDS, the root role must be assigned the role the database is being created with
    a. This is a weird RDS requirement where the root role isn't really "super"
  4. The debug print statements in the init script were printing out the raw database password every single run
    a. Even though our logs are private, this is still a serious issue
    b. The debug statements were moved to the entrypoint instead so they could be conditionally controlled
  5. The ideascale SQL for the dev environment had a syntax error in it

@jmgilman jmgilman changed the title fix: cleans up eventdb entrypoint and adds fix for RDS fix: cleans up eventdb entrypoint and adds fix for RDS | NPG-000 Apr 9, 2024
stevenj
stevenj previously approved these changes Apr 10, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 enabled auto-merge (squash) April 10, 2024 09:27
@kukkok3 kukkok3 self-requested a review April 10, 2024 09:27
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 merged commit e112088 into main Apr 10, 2024
59 of 60 checks passed
@kukkok3 kukkok3 deleted the fix-eventdb-init branch April 10, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants