Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add allocation generation step and preparing reviews for import | NPG-7896 #521

Merged
merged 16 commits into from
Aug 22, 2023
Merged

feat: Add allocation generation step and preparing reviews for import | NPG-7896 #521

merged 16 commits into from
Aug 22, 2023

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Aug 16, 2023 •
edited
Loading

Description

  • Added allocations generation step to review importer tool.
  • Added preparing reviews step to review importer tool.
  • Update config loading, load configs from the event-db.

@Mr-Leshiy Mr-Leshiy self-assigned this Aug 16, 2023
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Aug 16, 2023
@Mr-Leshiy Mr-Leshiy requested review from FelipeRosa, stevenj and minikin and removed request for FelipeRosa August 16, 2023 14:09
@minikin minikin enabled auto-merge (squash) August 16, 2023 14:14
@Mr-Leshiy Mr-Leshiy marked this pull request as draft August 17, 2023 07:54
auto-merge was automatically disabled August 17, 2023 07:54

Pull request was converted to draft

@Mr-Leshiy Mr-Leshiy added do not review yet Do not review yet and removed review me PR is ready for review labels Aug 17, 2023
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review August 21, 2023 11:28
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review and removed do not review yet Do not review yet labels Aug 21, 2023
@Mr-Leshiy Mr-Leshiy changed the title feat: Add allocation generation step to review importer | NPG-7896 feat: Add allocation generation step and preparing reviews for import | NPG-7896 Aug 21, 2023
@minikin minikin enabled auto-merge (squash) August 21, 2023 12:01
FelipeRosa
FelipeRosa approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

utilities/ideascale-importer/ideascale_importer/reviews_importer/processing/prepare.py Show resolved Hide resolved
@minikin minikin merged commit 40c5961 into main Aug 22, 2023
25 checks passed
@minikin minikin deleted the feature/review-importer branch August 22, 2023 03:08
stevenj
stevenj approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

@FelipeRosa FelipeRosa FelipeRosa approved these changes

@minikin minikin Awaiting requested review from minikin

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mr-Leshiy @stevenj @FelipeRosa @minikin