Skip to content

Conversation

@oldGreg5
Copy link
Contributor

@oldGreg5 oldGreg5 commented Sep 15, 2025

Description

CI runs fine without it and all our integration tests using python-base as well.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #123, Resolves #456 Fixes #367

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@oldGreg5 oldGreg5 added the do not merge yet PR is not ready to be merged yet label Sep 15, 2025
@oldGreg5 oldGreg5 added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Sep 15, 2025
@oldGreg5 oldGreg5 requested a review from kukkok3 September 15, 2025 12:57
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@github-project-automation github-project-automation bot moved this from New to 🔖 Ready in Catalyst Sep 16, 2025
@oldGreg5 oldGreg5 requested a review from kukkok3 September 16, 2025 12:28
@oldGreg5 oldGreg5 removed the do not merge yet PR is not ready to be merged yet label Sep 16, 2025
@oldGreg5 oldGreg5 enabled auto-merge (squash) September 16, 2025 12:28
@oldGreg5 oldGreg5 disabled auto-merge September 16, 2025 12:28
@oldGreg5 oldGreg5 enabled auto-merge (squash) September 16, 2025 12:29
@oldGreg5 oldGreg5 changed the title chore(general): Ci building time experiments chore(general): Remove Rust from python-base image Sep 16, 2025
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oldGreg5 oldGreg5 merged commit 52b5a37 into master Sep 16, 2025
38 checks passed
@oldGreg5 oldGreg5 deleted the ci-building-time-experiments branch September 16, 2025 12:32
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Catalyst Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants