Skip to content

feat(ci): Clarify hdf5 src license and fix hermes related CI issues #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
May 14, 2025
Merged

feat(ci): Clarify hdf5 src license and fix hermes related CI issues #400

merged 42 commits into from
May 14, 2025

Conversation

@stevenj
Copy link
Collaborator

@stevenj stevenj commented May 13, 2025 •
edited
Loading

Description

CI Updates that were required to get Hermes building with the latest CI.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

stevenj and others added 28 commits April 22, 2025 19:38
@stevenj
fix(python): Python Lints.
4c67d54
@stevenj
fix(python): Fix comment in Justfile
5e9ecf8
@stevenj
fix(python): spelling fixes
6f6b3d8
@stevenj
fix(python): Remove subprocess._ENV it doesn't exist...
013e941
@stevenj
fix(python): name named parameters
6d23805
@stevenj
fix(python): Name non positional parameters
0cac860
@stevenj
fix(python): disable lints for print
e75166d
@stevenj
fix(python): fix more bool flags
a015102
@stevenj
fix(python): Its ok if the docs dir exists
f2de03d
@stevenj
fix(python): bin was renamed to bin_file
77466cd
@stevenj
fix(python): filename needs to be a string not a path
aad8c15
@stevenj
fix(python): Make indent default to 0, not None.
9b5b25d
@stevenj
fix(python): Use relative includes for files in sub directories.
1ac3bad
@stevenj
docs(python): Update mkdocs and fix relative includes.
80462b4
@stevenj
fix(python): Bump to python 13
5ca8966
@stevenj
Merge branch 'master' into feat/include-relative-docs
4f75ca4
@stevenj
fix(python): update dependencies as it no longer builds
f8308a0
@stevenj
Merge branch 'feat/include-relative-docs' of github.com:input-output-…
967ef2f 
…hk/catalyst-ci into feat/include-relative-docs
@stevenj
fix(python): update docs
c96cfb6
@stevenj
Merge branch 'master' into feat/include-relative-docs
3089a27
@stevenj
fix(python): add UV to base python builder
956ff64
@stevenj
fix(python): Add UV to the path
f9e5421
@stevenj
feat(rust): clarify the license for hdf5-metno-src
6791e6c
@stevenj
fix(rust): change license path
3214631
@stevenj
fix(rust): try a different license file
f898fb9
@stevenj
fix(rust): replace original hdf5-src license clarification
631249f
@stevenj
fix: sync wit-bindgen with hermes requirements
47106e5 
\
@stevenj
fix(rust): deny.toml updated in rust example
c49b768
@stevenj stevenj self-assigned this May 13, 2025
@stevenj stevenj added do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels May 13, 2025
@stevenj stevenj changed the title Feat(ci): Clarify hdf5 src license feat(ci): Clarify hdf5 src license May 13, 2025
@stevenj stevenj removed do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels May 14, 2025
@stevenj stevenj moved this from New to 👀 In review in Catalyst May 14, 2025
@stevenj stevenj changed the title feat(ci): Clarify hdf5 src license feat(ci): Clarify hdf5 src license and fix hermes related CI issues May 14, 2025
@stevenj stevenj enabled auto-merge (squash) May 14, 2025 15:33
saibatizoku
saibatizoku approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit f694dda into master May 14, 2025
36 checks passed
@stevenj stevenj deleted the feat/clarify-hdf5-src-license branch May 14, 2025 15:55
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saibatizoku saibatizoku saibatizoku approved these changes

@Mr-Leshiy Mr-Leshiy Awaiting requested review from Mr-Leshiy

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees

@stevenj stevenj

Labels

None yet

Projects

Catalyst
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stevenj @saibatizoku