Skip to content

Conversation

@kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Mar 14, 2025

Description

This PR adds a target to run web tests on flutter and a function to create a patched chrome to overwrite the parameters that flutter passes to chrome

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #123, Resolves #456 Fixes #367

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@kukkok3 kukkok3 marked this pull request as ready for review March 18, 2025 10:13
@kukkok3 kukkok3 requested review from dt-iohk, emiride and oldGreg5 and removed request for oldGreg5 March 18, 2025 15:16
@kukkok3 kukkok3 enabled auto-merge (squash) March 18, 2025 15:19
@kukkok3 kukkok3 requested a review from dt-iohk March 19, 2025 09:24
@dt-iohk
Copy link
Contributor

dt-iohk commented Mar 19, 2025

@kukkok3 can you please update project fields? One of the checks failed due to them

@kukkok3 kukkok3 self-assigned this Mar 19, 2025
@kukkok3 kukkok3 moved this from New to 👀 In review in Catalyst Mar 19, 2025
@kukkok3 kukkok3 added the review me PR is ready for review label Mar 19, 2025
@kukkok3
Copy link
Contributor Author

kukkok3 commented Mar 19, 2025

@kukkok3 can you please update project fields? One of the checks failed due to them

Looking at the error I think the check is broken??

Copy link
Contributor

@dt-iohk dt-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 merged commit 9238e8f into master Mar 19, 2025
70 of 72 checks passed
@kukkok3 kukkok3 deleted the test/adds-flutter-web-unit-tests branch March 19, 2025 10:24
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants