Skip to content

Conversation

@oldGreg5
Copy link
Contributor

@oldGreg5 oldGreg5 commented Feb 6, 2025

Description

Add installing chrome in playwright container

Related Issue(s)

input-output-hk/catalyst-voices#1132

Description of Changes

Add installing chrome from our storage in playwright container.
Run with changes here

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@oldGreg5 oldGreg5 changed the title add installing chrome in playwright container feat: add installing chrome in playwright container Feb 6, 2025
@oldGreg5 oldGreg5 self-assigned this Feb 6, 2025
@oldGreg5 oldGreg5 added the review me PR is ready for review label Feb 6, 2025
@minikin minikin enabled auto-merge (squash) February 6, 2025 08:37
@minikin minikin self-requested a review February 6, 2025 08:37
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin merged commit 3a5dae3 into master Feb 6, 2025
39 of 40 checks passed
@minikin minikin deleted the make-playwright-use-ci-browsers branch February 6, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants