Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 11, 2024

Description

allow target to have multiple hyphenated alphanumeric sequence

Related Issue(s)

Description of Changes

  • Add test case for target-test-test2 and target-test-test3
  • Fix doc
  • Fix regex to allow multiple hyphenated alphanumeric sequence

Breaking Changes

Screenshots

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 862b83a into master Jan 11, 2024
@stevenj stevenj deleted the fix/target-wildcard branch January 11, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants