Skip to content

Conversation

@alicechaitea
Copy link
Contributor

@alicechaitea alicechaitea commented Jan 9, 2024

Description

Migrate UDC to FUNCTION

Related Issue(s)

Closes: #109

Description of Changes

  • Migrated all UDCs and docs referencing them to FUNCTION
  • Enabled use of FUNCTION on Earthly 0.7

Breaking Changes

Screenshots

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@alicechaitea alicechaitea changed the title update: fdc deprecation fix: fdc deprecation Jan 9, 2024
@stevenj stevenj changed the title fix: fdc deprecation fix: UDC deprecation Jan 9, 2024
```yaml
- name: Setup Remote Runner
uses: input-output-hk/catalyst-ci/actions/configure-runner@master
uses: input-output-hk/catalyst-ci/actions/configure-runner@fdcDeprecation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to change this since it is a martdown file, but it is okay, just remember to change it back to

The first target we are going to consider will be responsible to prepare a PostgreSQL environment (Earthly `+postgres-base` target),
migrations, migrations configuration and seed data (`COPY --dir ./migrations ./data ./refinery.toml .`),
doing some final build step (Earthly `+BUILDER` UDC target).
doing some final build step (Earthly `+BUILDER` Function target).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the word "target"

with poetry via `+python-base` target.
Next step is to copy source code of the project and finally finalize the build
with some poetry project setup which is done with `+BUILDER` UDC target.
with some poetry project setup which is done with `+BUILDER` Function target.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

any other irrelevant stuff should omitted.
And finally finalize the build with `+SETUP` UDC target.
The `+SETUP` UDC target requires `rust-toolchain.toml` file,
And finally finalize the build with `+SETUP` Function target.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

The first step of building process it preparing a source files.
It is mandatory to have a `src` directory with all documentation md files in it and `mkdocs.yml` file.
This directory and file will be picked during the execution of `+SRC` UDC target.
This directory and file will be picked during the execution of `+SRC` Function target.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@alicechaitea alicechaitea requested a review from bkioshn January 17, 2024 02:51
@alicechaitea alicechaitea deleted the fdcDeprecation branch January 17, 2024 03:50
@alicechaitea alicechaitea restored the fdcDeprecation branch January 17, 2024 04:35
@alicechaitea alicechaitea reopened this Jan 17, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit c770647 into master Jan 17, 2024
@stevenj stevenj deleted the fdcDeprecation branch January 17, 2024 09:46
@Mr-Leshiy Mr-Leshiy restored the fdcDeprecation branch January 17, 2024 14:49
@Mr-Leshiy Mr-Leshiy deleted the fdcDeprecation branch January 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Migrate Earthly UDCs to FUNCTIONS in prepration for Earthly v0.8

5 participants