feat: bip32account bip32ed25519 dependency injection LW-12941 #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example, TransactionHash is a Hash32ByteBase16 which is a HexBlob therefore: let hash: TransactionHash; let blob: HexBlob = hash; // this is valid, all hashes are hex blobs hash = blob; // this is still invalid, not all hex blobs are hashes in order to implement this, custom OpaqueString and OpaqueNumber implementation was replaced with Tagged type from type-fest BREAKING CHANGE: remove Hash28ByteBase16.fromEd25519KeyHashHex
mkazlauskas
changed the title
mkazlauskas
force-pushed
the
refactor/bip32account-bip32ed25519-di
branch
from
63462b1 to
71a93b5
Compare
mobile (react native) applications benefit from using native modules for cryptography; main reason for doing this is to prepare for DI besides that, it ended up a nice code simplification, as new blake2b interface is easier to use due to simpler API and type inference
our libsodium-based key derivation performs poorly when running in mobile BREAKING CHANGE: add a new 'dependencies' parameter in Bip32Account ctor
implementation of those methods no longer requires them to be async
mkazlauskas
force-pushed
the
refactor/bip32account-bip32ed25519-di
branch
from
71a93b5 to
b56110c
Compare
AngelCastilloB
approved these changes
May 30, 2025
mirceahasegan
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to be able to replace the key derivation function, because the one that is using libsodium is performing poorly in mobile environment
Proposed Solution
Main commit: 7faaab4
Important Changes Introduced
See commit messages