Skip to content

feat(tf): use GitHub API to commit tf state in CI #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(tf): use GitHub API to commit tf state in CI #198

wants to merge 1 commit into from

Conversation

@nrdxp
Copy link
Contributor

@nrdxp nrdxp commented Jan 6, 2023 •
edited
Loading

If we are running a terraform apply from GitHub Actions, the GH API will sign the commit for us.

@nrdxp nrdxp force-pushed the tf-gh-api-commit branch 9 times, most recently from cf41cfa to e42babf Compare January 6, 2023 06:02
@nrdxp
Copy link
Contributor Author

nrdxp commented Jan 6, 2023

@manveru, @dermetfan, not sure exactly what the CI error is, but the message in cicero shows something about an image, which seems unrelated to this change. I have already tested and confirmed that this still works both locally and in Mamba World CI so it should be safe to merge, but I'd love to have a green run anyway.

@nrdxp nrdxp requested review from johnalotoski and manveru January 6, 2023 06:20
@nrdxp nrdxp force-pushed the tf-gh-api-commit branch 2 times, most recently from 4262b02 to 4be4701 Compare January 6, 2023 06:24
dermetfan
dermetfan reviewed Jan 9, 2023
View reviewed changes
@dermetfan
Copy link
Contributor

dermetfan commented Jan 9, 2023 •
edited
Loading

The CI error was likely due to corrupted podman zfs state again. In #200 I updated tullia and switched CI to use the exec driver so we avoid podman. It was then failing due to #199 which is merged now so you can rebase your PR onto master. CI still fails with path '/nix/store/bi0jhag2n60ip4a6j13f9xhsib7gn2a8-nix' is not valid but I suspect that may be due to nix 2.8.1 that we have on the clients.

@nrdxp nrdxp force-pushed the tf-gh-api-commit branch from 4be4701 to a504a2e Compare January 9, 2023 15:57
@nrdxp
feat(tf): use GitHub API to commit tf-state in CI
0c7b695 
If we are running a terraform apply from CI, the GH API will sign the
commit for us and provide the correct identity.
@nrdxp nrdxp force-pushed the tf-gh-api-commit branch from a504a2e to 0c7b695 Compare January 9, 2023 16:12
@nrdxp
Copy link
Contributor Author

nrdxp commented Jan 12, 2023

Already using this with success from a tag:
https://github.com/input-output-hk/mamba-world/commits/tf

The error still seems unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dermetfan dermetfan dermetfan left review comments

@johnalotoski johnalotoski Awaiting requested review from johnalotoski

@manveru manveru Awaiting requested review from manveru

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nrdxp @dermetfan