Add support for NS delegation and MX records #70
+77
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method contained a subtle bug, namely not accepting domains having a suffix already into the target list. This probably never failed for anyone as external-dns does not allow targets with a period suffix anyway. canonicalizeDomainNames should also just use canonicalizeDomainName for consistency.
In external-dns, targets MUST NOT end with a period suffix (.). Designate however requires this.
thriqon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was already almost ready for NS and MX records, only canonicalization was missing.
The code for canonicalization was slightly buggy, refactored and fixed.
Tested with a real Designate setup.