Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube/Overlay buttons): Always repeat button doesn't work when the video is minimized #2293

Closed
5 tasks done
Aryan-Chauhan opened this issue Aug 3, 2024 · 2 comments
Closed
5 tasks done
Labels
Bug report Something isn't working

Comments

@Aryan-Chauhan
Copy link

Aryan-Chauhan commented Aug 3, 2024

Type

Error at runtime

Tools used

Revancify

Application

YT v19.16.39

Latest patches, integrations & ReVancify.

Bug description

If we use the yellow mode of Always Repeat Button, below 2 things happen:

  1. When the video ends, the video goes to 0:00 and stays at paused condition [Intended behaviour].
  2. If we play any video from some playlist or Watch Later, and it ends, the video goes to 0:00 and stays at paused condition [Intented behaviour].

But there is a bug, it is described below:

If the video ends while it is playing in the Miniplayer, then it just starts playing the video from the beginning.

In other words, if a video ends while it is playing in the Miniplayer, the yellow mode of Always Repeat Button won't be obeyed.

Screenshot_2024-08-03-20-52-23-79_f22faf49515899f9781ec174a4d85388

Error logs

No logs.

Solution

The yellow mode of Always Repeat Button should work even if the video ends while being in the Miniplayer View.

It works fine when videos end while being in Half Player View, Fullscreen View & Background Playback.

Additional context

To reproduce the bug, do this:

  1. Open any video and make the Always Repeat Button yellow.
  2. Go to the last 15 seconds of the video.
  3. Now swipe the video down, so that it keeps playing, but in the Miniplayer.
  4. Now let the video end.
  5. You will notice that the video restarts from the beginning, which shouldn't happen when the Always Repeat Button is yellow.

Device Environment

Realme 7 Pro

Android 12 (skin name: Realme UI 3.0)

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@Aryan-Chauhan Aryan-Chauhan added the Bug report Something isn't working label Aug 3, 2024
@Aryan-Chauhan Aryan-Chauhan changed the title bug (YT) : Yellow mode of Always Repeat Button sometimes doesn't work. bug (YT) : Yellow mode of Always Repeat Button doesn't work if the video ends while playing in Miniplayer. Aug 3, 2024
@inotia00 inotia00 changed the title bug (YT) : Yellow mode of Always Repeat Button doesn't work if the video ends while playing in Miniplayer. bug(YouTube/Overlay buttons): Always repeat button doesn't work when the video is minimized Aug 7, 2024
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Aug 7, 2024
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Aug 7, 2024
@inotia00
Copy link
Owner

inotia00 commented Aug 7, 2024

reflected in revanced-patches-4.12.1

@inotia00 inotia00 closed this as completed Aug 7, 2024
@hugobasith
Copy link

jppplP
L

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants