Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube/SponsorBlock): the new SponsorBlock segment popup doesn't show minutes in the timestamp #2263

Closed
5 tasks done
NoMorePizza opened this issue Jul 20, 2024 · 2 comments
Labels
Bug report Something isn't working

Comments

@NoMorePizza
Copy link

NoMorePizza commented Jul 20, 2024

Type

Cosmetic

Tools used

RVX Manager

Application

YouTube v19.16.39
Patches v4.10.2

Bug description

When timing a new segment, minutes are missing from the timestamp. It's just a visual bug, actual timestamp has minutes correctly in place, and segments will work fine. Manually editing segment timing shows the correct time, so no issues there.

In this popup timestamp is 00:38:931 when it should be 02:38.931.
20240720_064824

And this timestamp is 01:33:393 and it should be 01:15:33.393.
20240720_064849

Setting timing manually shows the correct time.
20240720_071635

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@NoMorePizza NoMorePizza added the Bug report Something isn't working label Jul 20, 2024
@NoMorePizza NoMorePizza changed the title bug(YouTube/SponsorBlock): pressing the new SponsorBlock segment button doesn't show minutes in the timestamp bug(YouTube/SponsorBlock): the new SponsorBlock segment popup doesn't show minutes in the timestamp Jul 21, 2024
@inotia00
Copy link
Owner

Process for reproducing the issue

  1. Include the SponsorBlock patch.
  2. Turn on Show create new segment button in SponsorBlock settings.
  3. Play any video and go to a time between 10 and 60 minutes. (e.g. 00:12:34)
  4. Click Create new segment button.
  5. Click Adjust button (◉).
  6. The timestamp is displayed as 00:34.000 instead of 12:34.000.

Additional context

RVX's SponsorBlock follows ReVanced's code exactly.
So this issue can also be reproduced in ReVanced.

Commit ReVanced/revanced-integrations@81251f9 is the direct cause of the issue.

Since this commit, the timestamp has the following format:
HH:SS:sss

To resolve the issue, the timestamp must have the following format:
MM:SS:sss

inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jul 26, 2024
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Jul 26, 2024
@inotia00
Copy link
Owner

reflected in revanced-patches-4.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants