Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube/Spoof client): change hardcoded device information in iOS clients #2261

Closed
5 tasks done
inotia00 opened this issue Jul 19, 2024 · 9 comments
Closed
5 tasks done
Labels
Feature request Requesting a new feature

Comments

@inotia00
Copy link
Owner

inotia00 commented Jul 19, 2024

Application

YouTube

Feature description

hdr

According to @0xrxL, spoofing from the latest YouTube client to the iOS client enabled HDR playback.

Additional context

  1. The device must support hardware AV1 decoding.

The following chipsets support hardware AV1 decoding:

Broadcom bcm72180+
Google Tensor G1+
MediaTek Dimensions 1000+
Realtek’s RTD1311+
Samsung Exynos 2100+
Snapdragon 8 Gen 2+

  1. The iOS device model in Spoof client must be iPhone16,1 (iPhone 15 Pro) or iPhone16,2 (iPhone 15 Pro Max).
    RVX is currently using the iPhone 15,3 (iPhone 14 Pro) when spoofing with the iOS client.

Among released iOS devices, the only ones that support hardware AV1 decoding are the iPhone16,1 (iPhone 15 Pro) or iPhone16,2 (iPhone 15 Pro Max).

  1. Spoof client patch should spoof user-agents.
    Currently Spoof client patch does not spoofing user-agents.

Also RVX currently uses iOS YouTube 19.01.1.

Motivation

Although there are many prerequisites, it is possible to get HDR playback on some devices when spoofing with an iOS client.

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@inotia00 inotia00 added the Feature request Requesting a new feature label Jul 19, 2024
@0xrxL
Copy link

0xrxL commented Jul 19, 2024

I can confirm that the same behaviour happen on another phone too, with a different account. Both are S23s (S23+ and a S23 Ultra).

Would be interesting to understand if user agent could really be used to enable HDR, or this fix it's just a thing related to a codec patch.

@inotia00
Copy link
Owner Author

The attached screenshot uses SM-S916B, and the chipset used in SM-S916B, Snapdragon 8 Gen 2, supports hardware AV1 decoding.

The patch will not work on Android Emulators that are not expected to support hardware AV1 decoding.

@0xrxL
Copy link

0xrxL commented Jul 19, 2024

The attached screenshot uses SM-S916B, and the chipset used in SM-S916B, Snapdragon 8 Gen 2, supports hardware AV1 decoding.

The patch will not work on Android Emulators that are not expected to support hardware AV1 decoding.

Yeah...but it's however weird that, with iPhone 16,1 and the same user agent patch, I wasn't able to enable HDR with previous versions.

For this reason I wondered what exactly fixed this lack.

@AlexDon228
Copy link

AlexDon228 commented Jul 19, 2024

Spoofing from the latest YouTube client to the Android Testsuite client enabled HDR playback.

Hardware AV01 decoding.

Chipsets MediaTek Dimensity 8100.

IMG_20240719_230334_390

@Aryan-Chauhan
Copy link

Does this mean this will unlock 1440p & 2160p even if user is using iOS client?

@0xrxL
Copy link

0xrxL commented Jul 20, 2024

Does this mean this will unlock 1440p & 2160p even if user is using iOS client?

Yes, I currently have only iOS spoof on my client, up to 2160p available...with HDR too.

@0xrxL
Copy link

0xrxL commented Jul 20, 2024

Spoofing from the latest YouTube client to the Android Testsuite client enabled HDR playback.

Hardware AV01 decoding.

Chipsets MediaTek Dimensity 8100.

IMG_20240719_230334_390

You must try with iOS spoof, not Testsuit. This thread is related to iOS spoof.

@AlexDon228
Copy link

You must try with iOS spoof, not Testsuit. This thread is related to iOS spoof.

In my case, HDR only plays when Android Testsuite spoof is enabled.
iOS, Android TV, Android VR spoof - disabled HDR playback.

Hardware AV01 decoding HDR - enabled HDR playback.
Hardware VP9.2 decoding HDR - disabled HDR playback.

inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Jul 27, 2024
…eVanced_Extended#2261

• No HDR video → HDR video is supported only on AV1 codec
• Higher video qualities may not be available → fixed
• Live streams not available on Android 8.0 → fixed
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jul 27, 2024
…eVanced_Extended#2261

• No HDR video → HDR video is supported only on AV1 codec
• Higher video qualities may not be available → fixed
• Live streams not available on Android 8.0 → fixed
@inotia00
Copy link
Owner Author

reflected in revanced-patches-4.10.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

4 participants