question(YouTube - RVX settings): Regarding copy-paste menu

[ILoveOpenSourceApplications]

Application

YouTube

Question description

When trying to either copy or paste something the menu for it is too large which ends up blocking what the user is trying to cut/copy/paste in the first place. This behavior is only present within the ReVanced settings menu only.

I remember this issue being present in RVX at some point but it isn't there anymore. So I wanted to ask whether you changed something regarding this and if there is a fix for it or not.

For further info: ReVanced/revanced-patches#3061

Acknowledgements

• This issue is not a duplicate of an existing question.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[inotia00]

This issue was fixed in the following commit:
inotia00/revanced-patches@4667cbf
inotia00/revanced-integrations@9e4ad2a

[inotia00]

Technical explanation is as follows:

1. The fragment in ReVanced settings uses Android Library, not AndroidX Library.

AndroidX Library was released in 2018, and most Android apps use AndroidX Library.
YouTube also used AndroidX Library in the settings fragment.

YouTube Vanced was released after 2018, and AndroidX Library was available at that time.
Why did TeamVanced use Android Library to implement fragment?

The answer to this question is that obfuscation has been applied to all classes related to the AndroidX Library applied to YouTube, making it nearly impossible to handle them in integration.

2. Why is AndroidX Library mentioned?

Because the cause of the issue lies here.

ReVance settings use the Theme.YouTube.Settings theme and the Theme.YouTube.Settings.Dark theme.

Theme.YouTube.Settings theme and Theme.YouTube.Settings.Dark theme are inherited from the AppCompat theme.

And AppCompat belongs to AndroidX Library.

In other words, the fragment in ReVanced settings uses the Android Library, but a theme that inherits the AndroidX Library is applied.

Android Library and AndroidX Library are compatible to some extent, but most are not compatible.

This causes issues.

As a counter-evidence, this issue does not reproduce in RVX Music.

Since setting fragment is not implemented in RVX Music settings, YouTube Music's fragment is used.

If you implement a separate fragment like this PR, this issue will be reproduced in YouTube Music.
ReVanced/revanced-patches#2708

3. What should I do to resolve the issue?

The issue can be solved by making the integration use the AndroidX Library, but as mentioned in Explanation 1, this is close to impossible.

The simplest way is to override the theme in Android Library in the situation where the issue is reproduced.

This is the workaround I chose.

[ILoveOpenSourceApplications]

Thanks @inotia00, for the detailed explanation. Much appreciated.