Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube Music/Hide layout components): add Hide settings menu setting #1899

Closed
5 tasks done
DesignVertex opened this issue Jan 11, 2024 · 4 comments
Closed
5 tasks done
Labels
Feature request Requesting a new feature

Comments

@DesignVertex
Copy link

Application

YouTube Music

Feature description

Please consider adding this in both RVX and RVX Music

Screenshot_20240111-091349

I want to hide some elements among these.

Motivation

Because of feels a lot clutter to me.

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@DesignVertex DesignVertex added the Feature request Requesting a new feature label Jan 11, 2024
@inotia00 inotia00 changed the title feat: Add Custom Filter to Hide some buttons in the settings page as well, just like account menu custom filter feat(YouTube Music): add Hide settings component patch Jan 15, 2024
@inotia00
Copy link
Owner

This patch will be implemented in YouTube Music soon.

The RVX Settings implemented in YouTube Music are integrated into the YouTube Music settings due to limitations in the patch structure.

In other words, the Hide settings menu setting implemented in YouTube Music can hide not only the YouTube Music settings but also the RVX Settings.

This is the difference from the Hide settings menu patch implemented in YouTube, and this will be indicated in the summary of the settings.

@inotia00 inotia00 changed the title feat(YouTube Music): add Hide settings component patch feat(YouTube Music/Hide layout components): add Hide settings menu setting Jul 26, 2024
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Jul 26, 2024
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jul 26, 2024
@inotia00
Copy link
Owner

reflected in revanced-patches-4.10.3

@Aryan-Chauhan
Copy link

Aryan-Chauhan commented Jul 27, 2024

Since "General" is the only matching word in stock settings and RVX settings, can a fix be expected from your side?

@inotia00
Copy link
Owner

No, that is an issue that cannot be fixed

That is why I marked it as an issue that occurs on both YouTube and YouTube Music in issue #2043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

3 participants